Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support queryable projection mappings for derived type mappings #412

Merged
merged 1 commit into from May 8, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented May 7, 2023

Adds a new if + is expression save derived type mapping to add support for derived type mappings in expressions.
Closes #409

@latonz latonz self-assigned this May 7, 2023
@latonz latonz marked this pull request as draft May 7, 2023 20:56
@latonz latonz requested a review from ni507 May 7, 2023 20:57
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Merging #412 (84f2c63) into main (e5e2d1c) will increase coverage by 0.18%.
The diff coverage is 86.15%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   91.73%   91.91%   +0.18%     
==========================================
  Files         126      131       +5     
  Lines        3931     4144     +213     
  Branches      548      570      +22     
==========================================
+ Hits         3606     3809     +203     
- Misses        214      221       +7     
- Partials      111      114       +3     
Impacted Files Coverage Δ
src/Polyfills/Nullable.cs 0.00% <0.00%> (ø)
...k.Mapperly.Abstractions/MapDerivedTypeAttribute.cs 0.00% <0.00%> (ø)
...iok.Mapperly.Abstractions/MapperIgnoreAttribute.cs 100.00% <ø> (ø)
...pperly.Abstractions/MapperIgnoreSourceAttribute.cs 100.00% <ø> (ø)
...pperly.Abstractions/MapperIgnoreTargetAttribute.cs 100.00% <ø> (ø)
...ok.Mapperly/Configuration/AttributeDataAccessor.cs 73.33% <66.66%> (-1.67%) ⬇️
src/Riok.Mapperly/Emit/SyntaxFactoryHelper.cs 95.35% <93.93%> (-0.23%) ⬇️
src/Riok.Mapperly/Configuration/MapDerivedType.cs 100.00% <100.00%> (ø)
src/Riok.Mapperly/Descriptors/Configuration.cs 95.00% <100.00%> (ø)
...Riok.Mapperly/Descriptors/MappingBuilderContext.cs 98.11% <100.00%> (+0.03%) ⬆️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz force-pushed the fix/queryable-derived-types branch from 3a00d6d to 84f2c63 Compare May 8, 2023 15:46
@latonz latonz marked this pull request as ready for review May 8, 2023 15:47
@latonz latonz enabled auto-merge (squash) May 8, 2023 15:47
@latonz latonz merged commit 98a44a0 into riok:main May 8, 2023
12 checks passed
@latonz latonz deleted the fix/queryable-derived-types branch May 8, 2023 16:00
@latonz latonz added this to the v2.9.0 milestone Jun 14, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use [MapDerivedType] with Map(IQueryable)
3 participants