Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map existing target sets correctly #500

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Jun 14, 2023

Closes #498

@latonz latonz self-assigned this Jun 14, 2023
@latonz latonz enabled auto-merge (squash) June 14, 2023 12:32
@latonz latonz force-pushed the 498-map-existing-target-set-correctly branch from 2db1b7d to f1f2369 Compare June 14, 2023 12:59
@latonz latonz changed the title fix: map existing target sets correct fix: map existing target sets correctly Jun 14, 2023
@latonz latonz added this to the v2.9.0 milestone Jun 14, 2023
@latonz latonz requested a review from CommonGuy June 14, 2023 13:22
@latonz latonz force-pushed the 498-map-existing-target-set-correctly branch from f1f2369 to adcc4c9 Compare June 14, 2023 14:54
@latonz latonz force-pushed the 498-map-existing-target-set-correctly branch from adcc4c9 to 3ab1c60 Compare June 14, 2023 14:55
@latonz latonz requested a review from CommonGuy June 14, 2023 14:56
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #500 (adcc4c9) into main (85347e4) will increase coverage by 0.05%.
The diff coverage is 84.61%.

❗ Current head adcc4c9 differs from pull request most recent head 3ab1c60. Consider uploading reports for the commit 3ab1c60 to get more accurate results

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
+ Coverage   91.96%   92.02%   +0.05%     
==========================================
  Files         147      147              
  Lines        4656     4663       +7     
  Branches      588      588              
==========================================
+ Hits         4282     4291       +9     
+ Misses        254      253       -1     
+ Partials      120      119       -1     
Impacted Files Coverage Δ
src/Riok.Mapperly/Helpers/SymbolExtensions.cs 93.16% <83.33%> (+1.85%) ⬆️
...iptors/MappingBuilders/EnumerableMappingBuilder.cs 97.74% <85.71%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz merged commit 38e6556 into riok:main Jun 14, 2023
13 of 14 checks passed
@latonz latonz deleted the 498-map-existing-target-set-correctly branch June 14, 2023 15:05
@github-actions
Copy link

🎉 This PR is included in version 2.9.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-only HashSet doesn't map correctly
2 participants