fix: prevent property backing field mapping #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMakkison
force-pushed
the
backing_field
branch
from
e22bcbc
to
f6a5c76
Compare
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 174 174
Lines 5977 5977
Branches 758 758
=======================================
Hits 5401 5401
Misses 410 410
Partials 166 166
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🎉 This PR is included in version 3.0.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent mapperly mapping a properties backing field
Description
When mapping inside another class, the mapper will attempt to map properties' backing fields, leading to invalid or strange code.
SymbolAccessorto check that field symbols don't have anAssociatedSymbolaka; is not a backing field.Fixes #599, see comment
Checklist