Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for Roslyn 4.7 #718

Merged
merged 1 commit into from Sep 14, 2023
Merged

feat: support for Roslyn 4.7 #718

merged 1 commit into from Sep 14, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Sep 5, 2023

Roslyn 4.7, C# 12 Preview, .NET 8.0

Description

Upgrades to .net8.0 / C#12 preview / Roslyn 4.7.
Fixes #682

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@latonz latonz self-assigned this Sep 5, 2023
@latonz
Copy link
Contributor Author

latonz commented Sep 5, 2023

We should probably await the first RC of .NET 8.0.

@latonz latonz mentioned this pull request Sep 5, 2023
7 tasks
@latonz latonz force-pushed the feat/roslyn-4-7 branch 3 times, most recently from 191a1d3 to b00663b Compare September 5, 2023 10:13
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #718 (48733b9) into main (1fed304) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   91.36%   91.30%   -0.07%     
==========================================
  Files         201      201              
  Lines        6651     6628      -23     
  Branches      821      821              
==========================================
- Hits         6077     6052      -25     
- Misses        385      387       +2     
  Partials      189      189              

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz force-pushed the feat/roslyn-4-7 branch 2 times, most recently from c434df5 to cb47d4b Compare September 5, 2023 12:35
@latonz latonz force-pushed the feat/roslyn-4-7 branch 3 times, most recently from 2233d21 to d66f89e Compare September 13, 2023 20:08
@latonz latonz marked this pull request as ready for review September 13, 2023 20:09
@latonz latonz merged commit 876713d into riok:main Sep 14, 2023
18 of 19 checks passed
@latonz latonz deleted the feat/roslyn-4-7 branch September 14, 2023 06:05
@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .NET 8.0 / Roslyn 4.7
2 participants