Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #18 #19

Closed
wants to merge 2 commits into from
Closed

Closes #18 #19

wants to merge 2 commits into from

Conversation

pavel
Copy link

@pavel pavel commented Aug 28, 2016

Fix for #18.
See the issue for details.

@pavel
Copy link
Author

pavel commented Aug 29, 2016

The test All the cli output logs are fine was failing prior this changes.

@pavel
Fixed cases of *.undefined glob used in watcher.
1fdb9c0 
Removed explicit watcher.add in the 'watch folder' test.
@pavel
Copy link
Author

pavel commented Aug 29, 2016 •
edited
Loading

Have no clue how on earth watch folder was working, as it was watching for glob: test/tags/**/*.undefined.
Fixing this and removing explicit watcher.add in test itself, makes the test pass.

@GianlucaGuarini
Copy link
Member

this issue could be fixed directly adding the CHOKIDAR_USEPOLLING env variable https://github.com/paulmillr/chokidar/blob/f17186dff7b27c67b17a644c333cc239b42827ba/CHANGELOG.md#chokidar-160-jun-22-2016 it's an edge case and the workaround it's fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavel @GianlucaGuarini