Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclosed ES6 template error with RegExp #114

Closed
jkirkwood opened this issue Mar 7, 2019 · 2 comments
Closed

Unclosed ES6 template error with RegExp #114

jkirkwood opened this issue Mar 7, 2019 · 2 comments
Labels

Comments

@jkirkwood
Copy link

See this jsfiddle: http://jsfiddle.net/5r6oj3pm/1/

The $ at the end of the regex is causing an "Unclosed ES6 template" error during compilation:

this.value = this.value.replace(new RegExp(`[^0-9.-]+$`, 'g'), '');

If I remove the $ everything works fine.

@GianlucaGuarini
Copy link
Member

For now just use the literal constructor https://next.plnkr.co/edit/FIqN5yUK7ZEkWfkn and everything should be fine. The upcoming riot@4 version has already solved these kind of issues with a real tag parser

@GianlucaGuarini
Copy link
Member

Fixed with the new compiler v4.0.0. Unfortunately the old compiler will not be able to handle this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants