Skip to content

Commit

Permalink
fixed: several issues with the expressions bindings
Browse files Browse the repository at this point in the history
  • Loading branch information
GianlucaGuarini committed Mar 31, 2018
1 parent 859263f commit 069894e
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 18 deletions.
18 changes: 9 additions & 9 deletions dom-bindings.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,15 @@
}, {})
}

function textExpression(node, expression, scope) {
node.childNodes[expression.childNodeIndex].textContent = expression.value(scope);
function textExpression(node, expression, value) {
node.childNodes[expression.childNodeIndex].textContent = value;
}

function valueExpression(node, expression, scope) {
node.value = expression.value(scope);
function valueExpression(node, expression, value) {
node.value = value;
}

function attributeExpression(node, expression, scope) {
const value = expression.value(scope);
function attributeExpression(node, expression, value) {
node[value ? 'setAttribute' : 'removeAttribute'](expression.name, value);
}

Expand All @@ -49,7 +48,8 @@
})
},
mount(scope) {
this.value = this.apply(scope);
this.value = this.evaluate(scope);
this.apply(this.value);

return this
},
Expand All @@ -64,7 +64,7 @@
return this
},
apply(value) {
return expressions[this.type](this.node, value)
return expressions[this.type](this.node, this, value)
}
});

Expand Down Expand Up @@ -192,7 +192,7 @@

var bindings = {
if: ifBinding,
defauult: defaultBinding,
default: defaultBinding,
each: eachBinding,
tag: tagBinding
}
Expand Down
2 changes: 1 addition & 1 deletion src/bindings/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import tagBinding from './tag'

export default {
if: ifBinding,
defauult: defaultBinding,
default: defaultBinding,
each: eachBinding,
tag: tagBinding
}
5 changes: 3 additions & 2 deletions src/expression.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ const Expression = Object.seal({
})
},
mount(scope) {
this.value = this.apply(scope)
this.value = this.evaluate(scope)
this.apply(this.value)

return this
},
Expand All @@ -22,7 +23,7 @@ const Expression = Object.seal({
return this
},
apply(value) {
return expressions[this.type](this.node, value)
return expressions[this.type](this.node, this, value)
}
})

Expand Down
3 changes: 1 addition & 2 deletions src/expressions/attribute.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
export default function attributeExpression(node, expression, scope) {
const value = expression.value(scope)
export default function attributeExpression(node, expression, value) {
node[value ? 'setAttribute' : 'removeAttribute'](expression.name, value)
}
4 changes: 2 additions & 2 deletions src/expressions/text.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export default function textExpression(node, expression, scope) {
node.childNodes[expression.childNodeIndex].textContent = expression.value(scope)
export default function textExpression(node, expression, value) {
node.childNodes[expression.childNodeIndex].textContent = value
}
4 changes: 2 additions & 2 deletions src/expressions/value.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export default function valueExpression(node, expression, scope) {
node.value = expression.value(scope)
export default function valueExpression(node, expression, value) {
node.value = value
}

0 comments on commit 069894e

Please sign in to comment.