Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #18 #20

Merged
merged 2 commits into from
Jun 13, 2021
Merged

fixes #18 #20

merged 2 commits into from
Jun 13, 2021

Conversation

GianlucaGuarini
Copy link
Member

This patch fixes elegantly #18

I could reuse your tests though, so thank you @kachurun

@GianlucaGuarini GianlucaGuarini mentioned this pull request Jun 12, 2021
Closed
@coveralls
Copy link

coveralls commented Jun 12, 2021 •
edited

Pull Request Test Coverage Report for Build 332

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 99.375%
Totals Coverage Status
Change from base Build 329: -0.003%
Covered Lines: 282
Relevant Lines: 282
💛 - Coveralls

kachurun
kachurun approved these changes Jun 13, 2021
View reviewed changes
src/template.js Outdated Show resolved Hide resolved
test/core.spec.js Show resolved Hide resolved
@GianlucaGuarini GianlucaGuarini force-pushed the feature/fix-empty-template-bindings branch from 2f6f503 to 494e426 Compare June 13, 2021 17:42
@GianlucaGuarini GianlucaGuarini merged commit e062b8c into dev Jun 13, 2021
@GianlucaGuarini GianlucaGuarini deleted the feature/fix-empty-template-bindings branch June 13, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kachurun kachurun kachurun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GianlucaGuarini @coveralls @kachurun