Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation maintainers #48

Closed
cognitom opened this issue Oct 29, 2015 · 21 comments
Closed

Translation maintainers #48

cognitom opened this issue Oct 29, 2015 · 21 comments

Comments

@cognitom
Copy link
Member

Hi guys, I'm so happy to see the progress on the translations!
zh, ja and fr have finished, and ru seems almost done, and de has many pages translated already.

I think we should invite them as a maintainer (collaborator) for each language. (if they say ok)
@GianlucaGuarini @aMarCruz @tipiirai @rsbondi how do you think?

language current ver. maintainer
en latest who?
es translating @aMarCruz
de translating @MartinMuzatko
fr v2.2.4 @sylvainpolletvillard
ja v2.2.3 @cognitom
ru translating @kfreiman
zh v2.2.4 @Centaur
@GianlucaGuarini
Copy link
Member

@cognitom I think it's a good idea I will see if I could give them the write permissions only on the riot.github.io repo

@kfreiman
Copy link
Contributor

ok

@cognitom
Copy link
Member Author

😄

@MartinMuzatko
Copy link
Contributor

Awesome :) I'm glad to help.

@GianlucaGuarini
Copy link
Member

I have invited all the contributors!

@cognitom
Copy link
Member Author

@GianlucaGuarini thanks a lot!

@sylvainpolletvillard
Copy link
Contributor

thank you, challenge accepted ;)

Can you give details about what does that implies ? Do we still work with pull requests ?

@GianlucaGuarini
Copy link
Member

Now all the collaborators have write permissions only on the riot.github.io repo

@cognitom
Copy link
Member Author

@sylvainpolletvillard the workflow would be like this. If it's just typo or something, you don't have to stick to PR, I think. Any feedback is welcome.

Translating

  • Create a new translation branch like fr/v2.2.4
  • Send PRs to the translation branch (or push your commits directory)
  • Merge it into master when the translation has done
  • Push a tag like v2.2.4-fr

Hot fix for your language

You can fix master as a hot fix only if you haven't started the translation branch yet.

  • Send PRs to the master branch (or push your commits directory)

artboard 1

@Centaur
Copy link
Contributor

Centaur commented Oct 30, 2015

Still got 403 trying to push to master.

@cognitom
Copy link
Member Author

@Centaur have you confirm the invitation already?
You might have received the mail, or you could see the invitation here.
https://github.com/riot

@Centaur
Copy link
Contributor

Centaur commented Oct 30, 2015

Ok. My bad. Checked the wrong email. Just pushed the polishment of zh/v2.2.4 doc. Still get some kind of git user.name display issue but the commits are working fine.

@cognitom
Copy link
Member Author

@Centaur nice ;-)
SewerRepo is you? If the issue continues, let us know. We'll ask the support of GitHub.

@Centaur
Copy link
Contributor

Centaur commented Nov 1, 2015

@cognitom Yes. SewerRepo was one of my github account that has been abandoned, but yesterday I incorrectly set my local git user.email to the one that linked to it. This has been fixed locally, SewerRepo account has been deleted on github and will not appear in the future. Sorry for the misoperation.

@cognitom
Copy link
Member Author

cognitom commented Nov 1, 2015

@Centaur no prob ;-)

@aMarCruz
Copy link
Contributor

aMarCruz commented Nov 5, 2015

@cognitom , spanish translation is at 80% in the origin/es/v2.2.4 branch.
have a good day/night.

@cognitom
Copy link
Member Author

cognitom commented Nov 5, 2015

@aMarCruz oh greeeat! I'll add es to the list above ;-)
Have a good day/night, you too.

@cognitom
Copy link
Member Author

cognitom commented Nov 5, 2015

OK, now the language selector has been added to our site 😄
http://riotjs.com/
Thank you all!

@tipiirai
Copy link
Contributor

tipiirai commented Nov 6, 2015

Looks good. Thank you!

@sylvainpolletvillard
Copy link
Contributor

@riot/collaborators I decided to stop maintaining the French translation and leave the Riot organization. The reason is that the most active contributor on this project @GianlucaGuarini has repeatedly shown aggressive and condescending behavior on Twitter towards other members of the open-source community. Sharing core values such as mutual respect is essential to preserve team cohesion. Also, public shaming from a core contributor gives a very bad public image of this whole organization, which is why I no longer want to be associated with it.

Thank you for inviting me in the first place. I hope you'll find out how to fix this and retrieve a convivial and motivating team spirit as it was one year ago.

@GianlucaGuarini
Copy link
Member

@sylvainpolletvillard thank you for your great contribution and good luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants