-
-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input numbers leave unprocessed expressions after upgrade to 2.6.0 #1957
Comments
This is critical for our app, so we have to downgrade to 2.5.0 :-( |
This works if you put in |
It was not removed according to the change log since 2.5.0, most likely On Tue, 23 Aug 2016, 19:45 Richard Bondi, notifications@github.com wrote:
|
I think this bug probably was introduced with 38ed5fb |
@GianlucaGuarini you are correct, that is the change. We originally did this in the compiler here and updating to replace A type number input can only accept numeric values so the string expression |
Unfortunately, the issue still persist with riot 2.6.1, even the original plunkr example still shows {value} inside of the input in IE... |
Use 0 instead of null, it does not make any sense to set null value to an input type number |
Null is the same as undefined - no value. On Thu, 25 Aug 2016, 11:10 Gianluca Guarini, notifications@github.com
|
@cbxp I am afraid that clearing the input values in case of expressions returning null or undefined could be a breaking change. I will fix this behavior in riot@3.0.0. For now just use 0 for input type number with no values. In any case this is a IE bug and not really related to riot |
But shouldn't riot always clear its expressions from the output? Expression On Sat, Aug 27, 2016 at 4:26 PM Gianluca Guarini notifications@github.com
|
Just a reminder: the original plnkr test case still fails in IE. I have debugged IE and found where the problem is: The error is on line 108 of update.js. The point is, even if value is null, riot should still set it for the first time. Currently it skips it altogether, which is a bug. |
@cbxp for now just use |
Yes, riot-value works as a workaround, but it would be better to have a On Wed, 14 Sep 2016, 22:14 Gianluca Guarini, notifications@github.com
|
Chrome masks this bug because it doesn't allow non-numbers in input[type=number] fields, but you can clearly see in the Inspector that values contain unprocessed expressions for falsy values (even zero).
Open in IE to fully see the extent of the problem.
http://plnkr.co/edit/Ic2hW5DXtgVD71pVTyR7?p=preview
The text was updated successfully, but these errors were encountered: