Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text expressions + static text rendering issue #2701

Closed
1 of 7 tasks
GianlucaGuarini opened this issue Jun 4, 2019 · 3 comments
Closed
1 of 7 tasks

Text expressions + static text rendering issue #2701

GianlucaGuarini opened this issue Jun 4, 2019 · 3 comments
Assignees
@GianlucaGuarini
Labels
bug fixed

Comments

@GianlucaGuarini
Copy link
Member

Help us to manage our issues by answering the following:

  1. Describe your issue:

Text expressions mixed with static text will be not properly rendered

  1. Can you reproduce the issue?

https://next.plnkr.co/edit/4wDQLuNpkyzhdpmL

  1. On which browser/OS does the issue appear?

  2. Which version of Riot does it affect?

Only Riot.js@4.0.5

  1. How would you tag this issue?
  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@GianlucaGuarini GianlucaGuarini self-assigned this Jun 4, 2019
@GianlucaGuarini
Copy link
Member Author

Ok apparently the issue appears only in the minified version of riot+compiler.js

In the normal version everything works fine
https://next.plnkr.co/edit/zrCTYfRsd21c6PB0

@GianlucaGuarini
Copy link
Member Author

It's definitely a @riotjs/parser issue... I am on it

GianlucaGuarini added a commit to riot/compiler that referenced this issue Jun 5, 2019
@GianlucaGuarini
fixed: expressions parts issue riot/riot#2701
47e3fdf
GianlucaGuarini added a commit that referenced this issue Jun 5, 2019
@GianlucaGuarini
fixes #2701
d48896b
@GianlucaGuarini
Copy link
Member Author

Fixed in Riot.js@4.0.8 https://next.plnkr.co/edit/hK3Y8G0yYl1bH1Nv

GianlucaGuarini added a commit that referenced this issue Jun 7, 2019
@GianlucaGuarini
Merge branch 'master' into dev
15d5bf3 
* master:
  Create FUNDING.yml
  4.0.8
  fixes #2701
  4.0.7
  fixes #2703 replacing babel-minify
  4.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GianlucaGuarini GianlucaGuarini

Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GianlucaGuarini