Riot compiler uses trimStart and trimEnd rather than trimLeft and trimRight

[joshuakb2]

Help us to manage our issues by answering the following:

1. Describe your issue:

When interpolating 2 JavaScript expressions into the same string in a riot tag, the String.prototype.trimStart and trimEnd functions get used, but they does not exist in Node until v10.

According to the package.json, the intent is to support Node v8.

trimLeft and trimRight are available prior to Node v10 and have the same behavior as trimStart and trimEnd respectively, so we should use that instead.

2. Can you reproduce the issue?

I created a Github repository to demonstrate the issue: https://github.com/joshuakb2/riot-trimStart-bug

3. On which browser/OS does the issue appear?

Ubuntu 19.10, Node 8.17.0

4. Which version of Riot does it affect?

v4.12.0

5. How would you tag this issue?

• Question
• Bug
• Discussion
• Feature request
• Tip
• Enhancement
• Performance

[GianlucaGuarini]

Duplicate of riot/compiler#129

[GianlucaGuarini]

I reopened it only to remember to update the node key in the package.json file

[joshuakb2]

When I change trimStart to trimLeft and trimEnd to trimRight, I don't have any issues with node 8. Is there a reason not to continue supporting the older node version?

[GianlucaGuarini]

Is there a reason not to continue supporting the older node version?

Yes maintenance costs, performance issues without getting any real benefit. The new Riot.js Compiler supports modern browsers and Node 10 please consider upgrading.

[joshuakb2]

Cool! Thanks for clarifying.

[GianlucaGuarini]

This issue was fixed in riot@4.12.1. I'll need to support node8 because the missing features were breaking edge as well (and we need to support edge).