Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this in expression being compiled as scope.this #2876

Closed
3 of 7 tasks
Kal-Aster opened this issue Jul 17, 2020 · 4 comments
Closed
3 of 7 tasks

this in expression being compiled as scope.this #2876

Kal-Aster opened this issue Jul 17, 2020 · 4 comments
Assignees
@GianlucaGuarini
Labels
bug low priority

Comments

@Kal-Aster
Copy link

Help us to manage our issues by answering the following:

  1. Describe your issue:

Shouldn't be possible to use this in expressions?
I remember I did, but I'm not sure, by the way now, any this is being compiled as scope.this.

  1. Can you reproduce the issue?

Codesandbox

  1. On which browser/OS does the issue appear?

Last firefox by now

  1. Which version of Riot does it affect?

Last version by now

  1. How would you tag this issue?
  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@Kal-Aster
Copy link
Author

Rectifying: not always, because it seems to compile it correctly when using this.update

@GianlucaGuarini GianlucaGuarini self-assigned this Jul 18, 2020
@GianlucaGuarini
Copy link
Member

@EliteXXL can you please crate an example reproducing the issue?

@Kal-Aster
Copy link
Author

Sorry I overwritten that example trying that thing of this.update, now it reproduces the issue

GianlucaGuarini added a commit to riot/compiler that referenced this issue Jul 18, 2020
@GianlucaGuarini
added: tests for riot/riot#2876
f4cb8e2
GianlucaGuarini added a commit to riot/compiler that referenced this issue Aug 14, 2020
@GianlucaGuarini
added: tests for riot/riot#2876
3e6ef42
GianlucaGuarini added a commit to riot/compiler that referenced this issue Aug 14, 2020
@GianlucaGuarini
added: tests for riot/riot#2876
6c8763a
GianlucaGuarini added a commit that referenced this issue Aug 14, 2020
@GianlucaGuarini
closes #2876
6710fc5
@GianlucaGuarini
Copy link
Member

Fixed in Riot.js@4.13.5

This was referenced Jun 6, 2021
Open
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GianlucaGuarini GianlucaGuarini

Labels
bug low priority
Projects
None yet
Milestone
No milestone
2 participants
@GianlucaGuarini @Kal-Aster