Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute [content={ true | false }] broke components with slots #2913

Closed
1 of 7 tasks
kachurun opened this issue May 21, 2021 · 1 comment
Closed
1 of 7 tasks

Attribute [content={ true | false }] broke components with slots #2913

kachurun opened this issue May 21, 2021 · 1 comment
Assignees
Labels

Comments

@kachurun
Copy link
Contributor

kachurun commented May 21, 2021

Help us to manage our issues by answering the following:

  1. Describe your issue:
    When I add "content=true" attribute to child component with <slot/> inside Riot.js fails:
    https://codesandbox.io/s/riotjs-5-bug-template-forked-f1mdg?file=/my-tag.riot

But if I insert more than one child component it worked, but lost host tag:
https://codesandbox.io/s/riotjs-5-bug-template-forked-x5vv5?file=/my-tag.riot

  1. Can you reproduce the issue?
    https://codesandbox.io/s/riotjs-5-bug-template-forked-f1mdg?file=/my-tag.riot
    https://codesandbox.io/s/riotjs-5-bug-template-forked-x5vv5?file=/my-tag.riot

  2. On which browser/OS does the issue appear?

  3. Which version of Riot does it affect?
    5.4.2

  4. How would you tag this issue?

  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@GianlucaGuarini GianlucaGuarini self-assigned this May 21, 2021
GianlucaGuarini added a commit to riot/dom-bindings that referenced this issue May 29, 2021
GianlucaGuarini added a commit that referenced this issue May 29, 2021
@GianlucaGuarini
Copy link
Member

Fixed in Riot.js@5.4.3 thank you for reporting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants