-
-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using :is(a, b) selector in style tag breaks #2967
Comments
Thank you for your quick fix. I looked at the current fix and there might be a problem I believe that if you use "is()" multiple times, it will only reflect on the right side. For example using this selector Isn't the output like this? I apologize if I'm wrong. |
@webgoto no the patch works with your example as well. I have added a test for it just in case. Thank you for your feedback |
Thank you for confirming |
sorry. An incorrect example is used for testing. For example using this selector buggy output(used for testing) correct output |
Thank you for your feedback I think now it should work fine. |
This has been fixed in |
I'm sorry many times. example
|
Thank you I will have a look at it |
I think this broke my app, potential reason: because i'm using escaped colons (:) e.g. .scale\:frame > * {
/* 4 */
margin: auto;
position: absolute;
top: 0;
right: 0;
bottom: 0;
left: 0;
}
.scale\:img {
/* 5 */
display: block;
height: auto;
max-width: 100%;
} possible? will quickly revert to last version of riot and confirm. It might be an edge case (don't know how many other devs write CSS classes like this, but it's valid CSS and shouldn't break imho) the suspicion that something changed in riot came up bc my production builds are fine, but there i'm using a local copy of riot (e.g. not the newest one) while for my dev environment i'm using latest. EDIT: Confirmed, switching back to 7.0.6 fixes the issue. |
Fixed in |
Thank you for fixing it, works again, awesome! |
Help us to manage our issues by answering the following:
My css
p :is(a, span){color: red;}
is output like this
my-tag p :is(a,[is="my-tag"] p :is(a,my-tag span),[is="my-tag"] span){color: red;}
Content that should be output
my-tag p :is(a, span),[is="my-tag"] p :is(a, span){color: red;}
I think the selector is split due to the inclusion of ","
I think it also happens with :not(), :where(), etc.
Can you reproduce the issue?
https://plnkr.co/edit/869A7mlEqgTxHJxA?preview
On which browser/OS does the issue appear?
windows10
Chromium: 105.0.5195.102
Which version of Riot does it affect?
riot 7.0.6
riot 3.13.2
Please also fix v3
How would you tag this issue?
The text was updated successfully, but these errors were encountered: