Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Get method to receive component implementation by its name #2999

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

kachurunus
Copy link
Contributor

Copy link
Member

@GianlucaGuarini GianlucaGuarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. There are a couple of things we might change before getting this merged:

  1. I am not sure that adding a new helper method to get the component implementations is a good idea. This feature might be a niche, we can make the COMPONENTS_IMPLEMENTATION_MAP again available here instead
  2. Please add unit tests for all the changes applied to the source code
  3. The typescript interfaces should be updated accordingly

src/api/get.js Outdated Show resolved Hide resolved
@kachurunus
Copy link
Contributor Author

Thank you for this PR. There are a couple of things we might change before getting this merged:

  1. I am not sure that adding a new helper method to get the component implementations is a good idea. This feature might be a niche, we can make the COMPONENTS_IMPLEMENTATION_MAP again available here instead
  2. Please add unit tests for all the changes applied to the source code
  3. The typescript interfaces should be updated accordingly

I've just added the necessary globals, but it would be best if you could check this discussion: #3001.

@GianlucaGuarini GianlucaGuarini merged commit fe0adc7 into riot:main Apr 26, 2024
@GianlucaGuarini
Copy link
Member

Thank you @kachurunus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants