Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag on standard element #569

Merged
merged 4 commits into from Apr 13, 2015
Merged

tag on standard element #569

merged 4 commits into from Apr 13, 2015

Conversation

rsbondi
Copy link
Contributor

@rsbondi rsbondi commented Apr 7, 2015

Replace <todo></todo> with <div riot-tag='todo'></div>
#295 #304

@GianlucaGuarini
Copy link
Member

It looks promising but you didn't add any test for this

@rsbondi
Copy link
Contributor Author

rsbondi commented Apr 7, 2015

I was going to add to tags.html, but I could not get the tests to run before the change, what am I missing?

@GianlucaGuarini
Copy link
Member

@rsbondi
Copy link
Contributor Author

rsbondi commented Apr 8, 2015

I just checked the todo app with the latest dist build and it does work on ie8 xp, thanks for pointing that out. I stepped through in the debugger to make sure that line was called

@tipiirai
Copy link
Contributor

tipiirai commented Apr 8, 2015

I'll merge this one after v2.0.14 is out. I want to play with this feature first. Thanks!

@GianlucaGuarini GianlucaGuarini merged commit 555db88 into riot:dev Apr 13, 2015
@GianlucaGuarini
Copy link
Member

merged and it works without any problem even on ie8.
Please @rsbondi could you update also the documentation?

@rsbondi
Copy link
Contributor Author

rsbondi commented Apr 13, 2015

Good to hear, I will update the docs.

@gsouf
Copy link

gsouf commented Apr 16, 2015

It would be better for normalization to use : data-riot-tag. It wont change the functionality, only respect html stanard

@tipiirai
Copy link
Contributor

Awesome.

@tipiirai
Copy link
Contributor

data-riot-tag is certainly uglier than riot-tag but sooner or later we must support that. I don't want to start answering to (constant) questions about the HTML standard. I'll personally continue using riot-tag.

@rsbondi
Copy link
Contributor Author

rsbondi commented Apr 18, 2015

The standard is beyond enforcement with the proliferation of angular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants