Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve multi named support on loop element #876

Merged
merged 4 commits into from
Jun 27, 2015

Conversation

antonheryanto
Copy link
Contributor

more multi named improvement on #831 as my commit 6e48d18 only solve partially and still problem on loop item

this commit limited only to handle static loop, dynamically change loop item will need more work

@GianlucaGuarini
Copy link
Member

@antonheryanto could you make an example please? What is the problem with the current version?

@antonheryanto
Copy link
Contributor Author

@GianlucaGuarini as shown in the test, its will fail with current version, will provides plunkr or jsfiddle

@antonheryanto
Copy link
Contributor Author

please check this plunker
default view will show the test fail, change to riot_with_compiler_fix.js will show its fixed

@GianlucaGuarini
Copy link
Member

Ok I got it thanks

GianlucaGuarini added a commit that referenced this pull request Jun 27, 2015
improve multi named support on loop element
@GianlucaGuarini GianlucaGuarini merged commit acf0900 into riot:dev Jun 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants