tmpl.js - complete rewrite #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tipiirai @GianlucaGuarini @cognitom @rsbondi , hi Last days I spent some time cleaning and testing tmpl.js, and reviewing its logic. This is the result. I wanted above all: backward compatibility, correct details that have generated bugs & issues, provide flexibility in the implementation, and facilities to understand the code through multiple comments; all without the code grew ...too (the minified size of this version is XXX bytes vs XXX bytes of the one in the master branch). But I have not had time to study other parts of riot, and how they interact with tmpl, so perhaps tmpl caller filters out characteristics that this code implements, and therefore has grown unnecessarily. EDIT: In testing with some issues, I think there are details in the compiler that cause these issues. The string received from tmpl is filtered, new characteristics are not so usefull, and in other cases, the output of tmpl is ignored. This file passed all riot tests and, in my opinion, is in beta phase and ready for testing on performance and in real environments, so please, break the code now. I'm test it in latest IE, FireFox, and Chrome. I will do some mobile tests later. Code is heavily commented 'cause today, we know what we doing, tomorrow... God knows? (Corrections are welcomed, the English is not my friend) #784 is fixed #744 is related to the compiler Thanks.
silly ampersand :[
Escaping the `'/'` char in te result of RegExp.scape is browser dependent.
|
this will be merged after the riot 2.2.2 release. Great job @aMarCruz ! |
|
Kudos 👏 |
|
Switch PR to reduced version of new-tmpl-2 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tipiirai, @GianlucaGuarini, @cognitom, @rsbondi
This days I spent some time cleaning and testing tmpl.js, and reviewing its logic.
This is the result.
I wanted above all: backward compatibility, correct details that have generated bugs & issues,
provide flexibility in the implementation, and facilities to understand the code through multiple comments; all without the code grew ...too
(the minified size of this version is 4,386 bytes vs 1,887 bytes of the one in the master branch).
But I have not had time to study other parts of riot, and how they interact with tmpl,
so perhaps tmpl caller filters out characteristics that this code implements, and
therefore has grown unnecessarily.
EDIT: In testing with some issues, I think there are details in the compiler that cause these issues. The string received from tmpl is filtered, new characteristics are not so usefull, and in other cases, the output of tmpl is ignored.
This file passed all riot tests and, in my opinion, is in beta phase, ready to test for
performance and in real environments, so please, break the code now.
I'm test it in latest IE, FireFox, and Chrome. I will do some mobile tests later.
Code is heavily commented 'cause today, we know what we doing, tomorrow... God knows?
#784 is fixed
#744 is related to the compiler
Thanks.