Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router with query param not working. #74

Closed
Qlio opened this issue Nov 28, 2016 · 1 comment
Closed

Router with query param not working. #74

Qlio opened this issue Nov 28, 2016 · 1 comment
Labels
bug

Comments

@Qlio
Copy link

Qlio commented Nov 28, 2016

I have route: /login?path=*

But when I go to url: http://localhost:8000/login?path=test, and of my routes handling this one.
@cognitom cognitom added the bug label Nov 29, 2016
@cognitom
Copy link
Member

@Qlio thanks for reporting. I've found a bug on this line.
https://github.com/riot/route/blob/v3.0.0/lib/index.js#L55

? should be escaped to \?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cognitom @Qlio