Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13 loader.query is not defined in webpack.config.js, cause error (Cannot convert undefined or null to object) #14

Merged
merged 1 commit into from Dec 25, 2017
Merged

Conversation

wata-lb
Copy link
Contributor

@wata-lb wata-lb commented Dec 25, 2017

If loader.query is not defined in webpack.config.js, getOptions is return null and Object.keys(query) is cause error.

function compile() in test/index.js, is use default option ({}), not cause this probrem.

I'm fix this pattern and write test case.

  • test environment : node --version -> v8.9.0

…turn null and Object.keys(query) is cause error.

I'm fix this pattern and write test case.
@GianlucaGuarini GianlucaGuarini merged commit afa6ba4 into riot:master Dec 25, 2017
@GianlucaGuarini
Copy link
Member

thank you so much!

@wata-lb wata-lb deleted the #13_cannot_convert_null_to_object branch December 26, 2017 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants