Postgres support: Corrected one typo, and added distinction between n…

…o rights and no data

infracheck/checks/postgres-primary-streaming-status

@@ -34,7 +34,7 @@ from infracheck.infracheck.checklib.postgres import BasePostgreSQL
 
 class PostgresReplicaCheck(BasePostgreSQL):
     def main(self, expected_status: str, expected_user: str) -> tuple:
-        return self.validate_replication_row_exists('SELECT state, username FROM pg_stat_replication;',
+        return self.validate_replication_row_exists('SELECT state, usename FROM pg_stat_replication;',
                                                     expected_status=expected_status, expected_user=expected_user)
 
 

infracheck/infracheck/checklib/postgres.py

@@ -35,10 +35,15 @@ def query(self, qstr: str):
     def validate_replication_row_exists(self, sql: str, expected_status: str, expected_user: str):
         out = self.query(sql)
         active_replications = len(out)
+        has_no_access_to_at_least_one_row = False
 
         for row in out:
             status, conn_info = row
 
+            if conn_info is None:
+                has_no_access_to_at_least_one_row = True
+                continue
+
             if status != expected_status and expected_user in conn_info:
                 return False, 'Expected "%s" status for conn_info="%s", got "%s"' % (
                     expected_status, conn_info, status
@@ -50,6 +55,9 @@ def validate_replication_row_exists(self, sql: str, expected_status: str, expect
                 )
 
         if active_replications == 0:
+            if has_no_access_to_at_least_one_row:
+                return False, "no replications active: possibly connection user has no permissions to view this data"
+
             return False, "no replications active"
 
         return False, "%i replications active, but none found for user '%s'" % (active_replications, expected_user)