#66: Improve tests for ArchivePackagingTask

src/core/rkd/core/standardlib/io.py

@@ -242,7 +242,9 @@ def _create_archive(self, path: str) -> Union[ZipFile, TarFile]:
             if self.archive_type == ARCHIVE_TYPE_ZIP:
                 return ZipFile(temp_path, 'w')
             elif self.archive_type == ARCHIVE_TYPE_TARGZ:
-                return TarFile(temp_path, 'w:gz')
+                return TarFile.open(temp_path, 'w:gz')
+            else:
+                raise Exception('Unknown archive type')
 
     def _make_sure_destination_directory_exists(self, path: str) -> None:
         if not self.dry_run:

src/core/tests/test_standardlib_io_archivepackagingtask.py

@@ -14,6 +14,60 @@
 class ArchivePackagingTaskTest(FunctionalTestingCase):
     backup_stdout = False
 
+    def test_packs_into_tar(self):
+        io = BufferedSystemIO()
+        task = ArchivePackagingBaseTask()
+        self.satisfy_task_dependencies(task, io=io)
+
+        temp = TempManager()
+        archive_path = temp.create_tmp_file_path()[0]
+
+        # configure
+        task.archive_path = archive_path
+        task.archive_type = 'tar+gzip'
+        task.add('./tests/internal-samples')
+        task.add(TEST_PATH, 'test.py')
+
+        # execute
+        task.execute(self.mock_execution_context(
+            task,
+            {
+                "--dry-run": False,
+                "--allow-overwrite": False
+            },
+            {}
+        ))
+
+        self.assertTrue(os.path.isfile(archive_path))
+
+    def test_archive_type_validation_fails_on_unknown_value(self):
+        """
+        Checks if archive_type parameter is validated
+
+        :return:
+        """
+
+        io = BufferedSystemIO()
+        task = ArchivePackagingBaseTask()
+        self.satisfy_task_dependencies(task, io=io)
+
+        task.archive_path = '/tmp/archive.tar.gz'
+        task.archive_type = 'tar+wtf'
+        task.add('./tests/internal-samples')
+        task.add(TEST_PATH, 'test.py')
+
+        with self.assertRaises(Exception) as exc:
+            task.execute(self.mock_execution_context(
+                task,
+                {
+                    "--dry-run": False,
+                    "--allow-overwrite": False
+                },
+                {}
+            ))
+
+        self.assertIn('Unknown archive type', str(exc.exception))
+
     def test_dry_run_just_prints_messages(self):
         """
         Check two things: