Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

fancy time period magic! #14

Closed
wants to merge 4 commits into from
Closed

fancy time period magic! #14

wants to merge 4 commits into from

Conversation

tmonk42
Copy link
Contributor

@tmonk42 tmonk42 commented Nov 22, 2011

Hacked this out this afternoon. Known issue - it's not catching :from or :until defined in .graph files on 'default' dashboard pages. Should be an easy fix. Added shortcut links for last hour/day/week to default dashboard.erb, but I think that's totally optional and was purely a shortcut for me.

@ripienaar
Copy link
Owner

Interesting :)

I'll need to take some time to review, it'll be a while as I am on the road atm but will check it out soon

@nstielau
Copy link
Contributor

Hey, I like this functionality. I handled it with query params, instead of a different URL, which I like a little better (since it can then work with either the fullscreen or regular layouts). I think it'd be nice to incorporate this into the existing template, so we don't duplicate the template for further changes. Cool stuff!

@rkrombho
Copy link

Uh I was also just implementing the same with a date/time picker being able to specify absolute and relative times in the header bar directly integrating into the dashboard.erb.
My backend code looks pretty similar to this pull (will commit it soon).
@ripienaar do you think you can review it soon? Otherwhise I would procceed with my own implementation.

@ripienaar
Copy link
Owner

I am quite snowed under right now and my develop environment is non existing, so it's a bit tough to test and merge this now till I sort myself out

@nstielau
Copy link
Contributor

Hey Nathan,

Can you check out the pull that was just merged and see if it fits your requirements? If so we can close this pull. Onward!

Thanks

@tmonk42
Copy link
Contributor Author

tmonk42 commented Mar 26, 2012

Love it, meets my needs!

@tmonk42 tmonk42 closed this Mar 26, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants