Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

convert to bootstrap thumbnails rather than rows when displaying images #86

Merged
merged 2 commits into from
Mar 14, 2013

Conversation

bwhaley
Copy link
Collaborator

@bwhaley bwhaley commented Mar 3, 2013

This PR fixes issue #85. It also switches from using Bootstrap rows to strictly thumbnails, which I think it more appropriate for an image grid. Anyone care to review this?

@bwhaley bwhaley closed this Mar 3, 2013
@bwhaley bwhaley reopened this Mar 3, 2013
@bwhaley
Copy link
Collaborator Author

bwhaley commented Mar 3, 2013

Woops, did not mean to close it.

@keymon
Copy link
Collaborator

keymon commented Mar 10, 2013

Works for me +1

bwhaley added a commit that referenced this pull request Mar 14, 2013
thumbnails rather than rows for image grid
@bwhaley bwhaley merged commit bbea040 into master Mar 14, 2013
@falkenbt
Copy link
Collaborator

actually... @bwhaley how do you define the image sizes now? The height/width settings in gdash.yaml or dash.yaml have no effect anymore because bootstraps span4 size is fixed. Or am I missing something?

@bwhaley
Copy link
Collaborator Author

bwhaley commented Apr 11, 2013

Adjusting graph_width and graph_height in gdash.yaml is working for me in all views.

800x500
800x500

500x250
500x250

@bwhaley
Copy link
Collaborator Author

bwhaley commented Apr 11, 2013

Hmm but I see your point, the image is the right size but pixel # is constrained by the span. I will poke at this later.

@toerkl
Copy link

toerkl commented Apr 11, 2013

Very interested in knowing how to have different sizes for different views. Detailed and thumbnail grid. If anyone could explain or show me documentation of how to do it it would be great

@bwhaley
Copy link
Collaborator Author

bwhaley commented Apr 11, 2013

@lindqt01 You can specify ?width=X&height=Y in your URL to change the size of the graph. Does that help?

@toerkl
Copy link

toerkl commented Apr 12, 2013

@bwhaley After clicking on one of the graphs you get a detailed view with default time intervals. I would like to have those graphs bigger and maybe less amount of columns. Is this possible to achieve with templates or do i need to go into the code for that?

@bwhaley
Copy link
Collaborator Author

bwhaley commented Apr 12, 2013

@falkenbt I fixed this in bwhaley/gdash@4f4bfb705153aaea8a6fccfaec958f515dcc07c6 by reverting to a table format and using container-fluid in the layout. This branch also fixes an issue in graph.erb where query parameters were not passed on to the detailed dashboard.

@bwhaley
Copy link
Collaborator Author

bwhaley commented Apr 12, 2013

@lindqt01 The graphs can be bigger by appending width=N&height=M in the query parameters (after this fix is merged, that is). There is currently no way to dynamically adjust the number of columns.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants