[FIX] pass source_currency params properly #1
Conversation
| @@ -7,6 +7,7 @@ describe('Ripple REST Client buildPayment', function() { | |||
|
|
|||
| before(function () { | |||
| client = new Client({ | |||
| api: 'http://localhost:5990/', | |||
There was a problem hiding this comment.
This should be hitting api.ripple.com
There was a problem hiding this comment.
Oh you're looking at an older version of the PR. Have fixed that. @wltsmrz
On Wednesday, March 11, 2015, wltsmrz notifications@github.com wrote:
In test/build_payment.js
#1 (comment)
:@@ -7,6 +7,7 @@ describe('Ripple REST Client buildPayment', function() {
before(function () {
client = new Client({
api: 'http://localhost:5990/',In a test? Why?
—
Reply to this email directly or view it on GitHub
https://github.com/ripple/ripple-rest-client/pull/1/files#r26258157.
Abiy Seifu | Software Engineer
Ripple Labs, Inc.
abiy@ripple.com | www.ripple.com
There was a problem hiding this comment.
ah, removed http://localhost:5990/ so it tests against api.ripple.com.
updated. thanks for catching it @wltsmrz
On Wed, Mar 11, 2015 at 2:42 PM, wltsmrz notifications@github.com wrote:
In test/build_payment.js
#1 (comment)
:@@ -7,6 +7,7 @@ describe('Ripple REST Client buildPayment', function() {
before(function () {
client = new Client({
api: 'http://localhost:5990/',What did you fix?
—
Reply to this email directly or view it on GitHub
https://github.com/ripple/ripple-rest-client/pull/1/files#r26258904.
Abiy Seifu | Software Engineer
Ripple Labs, Inc.
abiy@ripple.com | www.ripple.com
There was a problem hiding this comment.
Why would you use api.ripple.com in a test?
There was a problem hiding this comment.
We're testing agains the api.ripple.com because we want to catch breaks in future ripple-rest releases. In a future pull request, we'll have offline testing to make sure our internal (ripple-rest-client) logics work.
nerdylocks
force-pushed
the
fix/source_currency
branch
2 times, most recently
from
3a440f4
to
479bc1f
Compare
| } | ||
| sourceCurrenciesParam.source_currencies = sourceCurrenciesString; | ||
| sourceCurrenciesString = opts.source_currencies.join(','); | ||
| sourceCurrenciesString += !_.isEmpty(opts.from_issuer) ? '%20' + opts.from_issuer : ''; |
There was a problem hiding this comment.
Can we do encodeURI('+') instead?
nerdylocks
force-pushed
the
fix/source_currency
branch
2 times, most recently
from
6d00bca
to
2982594
Compare
|
LGTM. |
addresses RCNX-84 also, use api.ripple.com as a default [TEST] update build payment method add fixtures for buildPayment responses
- add lodash
nerdylocks
force-pushed
the
fix/source_currency
branch
from
2982594
to
2f84ac6
Compare
[FIX] pass source_currency params properly
addresses RCNX-84
also, use api.ripple.com as a default
[TEST] update build payment method
also add fixtures
[TASK] add lodash