Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening files fails on Windows sometimes #41

Closed
mDuo13 opened this issue Jun 19, 2019 · 0 comments
Closed

Opening files fails on Windows sometimes #41

mDuo13 opened this issue Jun 19, 2019 · 0 comments
Labels
bug

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Jun 19, 2019

Per XRPLF/xrpl-dev-portal#599 it looks like opening files without explicitly specifying the encoding is a problem because Windows defaults to latin-1 instead of utf-8.

Fixing this will require a system where I can reliably reproduce (can dig out a Windows laptop and see how it goes)...
@mDuo13 mDuo13 added the bug label Jun 19, 2019
iroskam added a commit to iroskam/dactyl that referenced this issue Jul 3, 2019
@iroskam
Closes ripple#41
7ede740 
Python uses system default encoding to open files.  On Windows the default
encoding is latin-1.  As a result dactyl will crash on Windows.

- added explicit utf-8 encoding parameter to all open() calls
@mDuo13 mDuo13 closed this as completed in eb7b2d1 Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mDuo13