Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifies whether an offer has been executed with OfferCreate. #782

Open
tequdev opened this issue Jul 14, 2023 · 3 comments
Open

Identifies whether an offer has been executed with OfferCreate. #782

tequdev opened this issue Jul 14, 2023 · 3 comments
Labels
design work needed This issue requires some UI design work

Comments

@tequdev
Copy link
Contributor

tequdev commented Jul 14, 2023

Currently on the top page of explorer, all OfferCreate transactions are represented by blue circles.

I can't determine if the Offer object was simply created or if the Offer was executed on the DEX.

Although the transaction type is the same, it would be easier to understand the network activity if it were possible to determine whether or not an execution actually happened.

@ckniffen
Copy link
Collaborator

This is a good idea but will require parsing transaction meta data to determine the display which is now static based on TransactionType. Will discuss with the design team what this will look like in addition to other transaction modifiers.

My main worry is this will complicate the design. cc: @bugsbunnies

@mvadari
Copy link
Collaborator

mvadari commented Jul 18, 2023

IMO this should be added to the Simple page for the transaction, but shouldn't affect the display on the home page

@bugsbunnies
Copy link
Collaborator

IMO this should be added to the Simple page for the transaction, but shouldn't affect the display on the home page

I agree, the homepage is just meant to be an overview. If we were to add more detailed context it can get very messy and the homepage icons shouldn't be a place for that

@mvadari mvadari added the design work needed This issue requires some UI design work label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design work needed This issue requires some UI design work
Projects
None yet
Development

No branches or pull requests

4 participants