Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ko-KR translation #791

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

catalyzejay
Copy link
Contributor

High Level Overview of Change

This PR adds Korean translations to the XRPL official repository, making it easier for Korean-speaking users worldwide to understand and access XRPL. The change includes all documents and guides, promoting internationalization for alerts and error messages, among others.

Context of Change

This change was necessitated by the growing need to make XRPL more accessible to non-English speaking users, particularly those who speak Korean. Given the increasing popularity of blockchain technology in Korea, providing a Korean translation is crucial for XRPL's broader adoption in the Korean community.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

TypeScript/Hooks Update

N/A - This PR doesn't touch TypeScript/Hooks as it primarily deals with documentation updates.

Before / After

Before this change, the XRPL repository was only accessible in English and Japanese. After this change, users can access the documentation and guides in Korean, making it more accessible to a wider audience.

Test Plan

To test this change, a series of reviews should be carried out by native Korean speakers to ensure that the translations are accurate and meaningful. These should cover all aspects of the documentation and user guides. These tests can be reproduced by any native Korean speaker.

@ckniffen ckniffen requested a review from pdp2121 August 9, 2023 21:03
@ckniffen ckniffen merged commit 68c82e3 into ripple:staging Aug 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants