fix: search in custom mode #806
Conversation
Custom mode searching did not work after the react-router 6 updates
| path.indexOf(buildPath(VALIDATOR_ROUTE, { identifier: '' })) === 0 | ||
|
|
||
| // NOTE: for submenus, remove `path` field and add `children` array of objects | ||
| export const navigationConfig: NavigationMenuAnyRoute[] = [ |
There was a problem hiding this comment.
Moved to fix circular dependencies.
| @@ -0,0 +1,29 @@ | |||
| import { buildPath } from '../shared/routing' | |||
There was a problem hiding this comment.
There's no code change in this file, right (just moving)? I did a quick skim and it doesn't look like it, but I figured I should confirm
There was a problem hiding this comment.
This is a new file. Its contents came from routes.ts to prevent circular dependencies caused by import routes into the Search component.
I spent an hour trying to get tests setup. I tried switching to the |
Can you add a TODO then? |
| return 'ledgers' | ||
| return { | ||
| type: 'ledgers', | ||
| path: buildPath(LEDGER_ROUTE, { identifier: id }), |
There was a problem hiding this comment.
Should this id be .toUpperCase() like the other IDs?
High Level Overview of Change
Custom mode searching did not work after the react-router 6 updates.
Type of Change
Test Plan
Adding tests for custom mode proved tricky. Want to get this fix out sooner.