fix: always specify api_version: 1
#835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clio` default the `api_version` to `2` and rippled` to `1`.
mvadari
reviewed
Sep 25, 2023
mvadari
approved these changes
Sep 25, 2023
Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
justinr1234
approved these changes
Sep 25, 2023
ckniffen
added a commit
that referenced
this pull request
Sep 28, 2023
Viewing old transactions was broken by #835. When sending `api_version: 1` to clio it will currently forward to a rippled node which is not full history. That will be addresses soon but until then wont send now that for every request. Explicitly send api_version to get `account_info` because we only want the result from the most recently validated ledger.
1 task
ckniffen
added a commit
that referenced
this pull request
Sep 28, 2023
Viewing old transactions was broken by #835. When sending `api_version: 1` to clio it will currently forward to a rippled node which is not full history. That will be addresses soon but until then wont send now that for every request. Explicitly send `api_version` when getting `account_info` because we only want the result from the most recently validated ledger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
cliodefaults theapi_versionto2and rippledto1`.Type of Change