fix: display hex-decoded currency in AMM transaction table #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdp2121
approved these changes
Oct 18, 2023
JST5000
reviewed
Oct 18, 2023
| i18nKey={ | ||
| type === 'Payment' | ||
| ? 'token_for_transaction_swap' | ||
| : 'token_for_transaction' |
There was a problem hiding this comment.
I'm not really sure what token_for_transaction means - is there a more descriptive label that could be used?
JST5000
reviewed
Oct 18, 2023
| const wrapper = createWrapper(withdrawMock) | ||
|
|
||
| expect(wrapper).toHaveText('\uE900 XRP and USD') | ||
| }) |
There was a problem hiding this comment.
Should there be one more case for the for case instead of just the and case?
There was a problem hiding this comment.
There should be but I discovered that case is currently impossible to hit. I have asked internally for clarification of a case when this should occur. Currently it seems like additional parsing needs to be added to look at SendMax.
mvadari
commented
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Update the AMM transaction table to use the Currency component to consolidate currency formatting logic
Type of Change