chore(deps): bump vite-plugin-svgr #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required changing the plugin config Replaces #861
Instead of mocking React.useState it instead mocks the child component which will set the error.
justinr1234
approved these changes
Nov 2, 2023
# Conflicts: # package-lock.json
jonathanlei
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Required changing the plugin config and fixing an already precarious test.
Replaces #861
Context of Change
I dont know what transitive dependency broke the NFT component test. Regardless it was an oddly written test. Mocking React's
useStatecould have other consequences. Instead the child component is mocked which when there is an error tells the NFTToken about it.Type of Change