feat: add loader to transactions section of homepage #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
changed the title
mvadari
changed the title
ckniffen
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds a loader to the ledger details displayed on the homepage, for when the transaction info takes a bit longer to load. It also adds a Σ to the total fees in the ledger, so it's clearer that it's not the average or base fee.
Context of Change
With the heavy load happening right now, some ledgers take a second or two to load all of the transactions. This makes it clearer that there isn't anything that's broken.
Type of Change
TypeScript/Hooks Update
N/A
Before / After
Test Plan
Works locally.