Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assorted prod performance fixes #909

Merged
merged 8 commits into from
Jan 5, 2024
Merged

fix: assorted prod performance fixes #909

merged 8 commits into from
Jan 5, 2024

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jan 2, 2024

High Level Overview of Change

This PR has several fixes:

  • Fixes some issues with Buffer still being used in the app (even though the polyfill is no longer there)
  • Fixes some issues with time calculations on ledgers
  • Shrinks the max ledger count from 20 to 15 to save memory
  • Optimizes the ledger and validation store to save memory on the home page

Context of Change

The recent high load on the ledger has been stretching the memory and performance limits of the Explorer.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

TypeScript/Hooks Update

N/A

Before / After

N/A

Test Plan

Fixes work locally. The optimizations shrink the object sizes by 25-30%.

@mvadari mvadari marked this pull request as ready for review January 4, 2024 21:23
@mvadari mvadari requested a review from ckniffen January 4, 2024 21:23
@ckniffen
Copy link
Collaborator

ckniffen commented Jan 5, 2024

Can you also update the Buffer usages in /src/rippled/NFTTransactions.ts, /src/rippled/lib/utils.js and src/index.html?

Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvadari mvadari merged commit 3d046a0 into staging Jan 5, 2024
4 checks passed
@mvadari mvadari deleted the prod-perf-fixes branch January 5, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants