fix: validator page validation vs ledger_closed race condition #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanlei
changed the title
jonathanlei
changed the title
ckniffen
reviewed
Jan 11, 2024
…to fix-vhs-logging-error
ckniffen
approved these changes
Jan 11, 2024
JST5000
reviewed
Jan 12, 2024
oh I thought it's okay to use abbreviation haha i've used indx in other code before |
Co-authored-by: Jackson Mills <aim4math@gmail.com>
It's not the end of the world, but it only saves a letter & can trip someone up when typing, so I figure writing it all out is better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
See issue #684
Context of Change
the validator page is stuck when retrieving info on a validator that has validated a ledger which doesn't have a state of validated or cannot be found, resulting in a "Something bad happened" page, see image:
Solution:
add error catching and log the error, return response anyway without last updated time and ledger index
Type of Change
Test Plan
added test in Validator.test.js