Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: smoother sliding of ledgers on homepage #924

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

ckniffen
Copy link
Collaborator

High Level Overview of Change

Updates the transition for new ledgers to be smoother by rendering the ledger as its full width off to the left and move it to the right.

Also update everywhere 0px was used to 0 in ledger.scss.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change that only restructures code)

Before

Ledger.Transition.Before.mp4

After

Ledger.Transition.After.mp4

Updates the transition for new ledgers to be smoother by rendering the
ledger as its full width off to the left and move it to the right.

Also update everywhere `0px` was used to `0` in `ledger.scss`.
@ckniffen ckniffen requested a review from a team January 25, 2024 22:34
@ckniffen ckniffen requested a review from a team January 25, 2024 22:39
Copy link
Collaborator

@justinr1234 justinr1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ckniffen ckniffen merged commit 377242c into staging Jan 26, 2024
4 checks passed
@ckniffen ckniffen deleted the bugfix/smoother-ledgers branch January 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants