-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add better error handling for transactions' Simple pages #939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bugsbunnies Should the message be something similar to the |
I copied the old error message/CSS that was displayed in the |
Make sense! |
Yeah that makes sense |
IMO the current error message is better, because this would exclusively be due to an Explorer error, rather than user error. But I'm happy to edit the CSS if you'd prefer that. |
High Level Overview of Change
This PR has better error handling if there is a bug in a transaction's
Simple
page. This results in better user experience when something is broken.This does add a package,
react-error-boundary
, but the package is very tiny and is quite useful.Context of Change
I encountered this while using the Explorer.
Type of Change
TypeScript/Hooks Update
N/A
Before / After
Before: a black screen
After:
Test Plan