Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move % on AMM Account Page #957

Merged
merged 3 commits into from
Mar 22, 2024
Merged

fix: move % on AMM Account Page #957

merged 3 commits into from
Mar 22, 2024

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Mar 22, 2024

High Level Overview of Change

This PR moves the % in the trading fee for AMM Account pages, and fixes a couple of deprecated function issues that were noticed in the process.

Context of Change

Noticed while looking at an AMM page.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

TypeScript/Hooks Update

N/A

Before / After

Before:
image

After:
image

Test Plan

Works locally.

@mvadari mvadari merged commit 8c6fab2 into staging Mar 22, 2024
4 checks passed
@mvadari mvadari deleted the % branch March 22, 2024 14:58
@mrT23
Copy link

mrT23 commented Mar 29, 2024

❌ PR-Agent: Missing component name in test command.

Please provide a component name when running the tool: /test <component_name>. Running automatically on the largest changed component.


✨ Test tool usage guide:

The test tool generate tests for a selected component, based on the PR code changes.
It can be invoked manually by commenting on any PR:

/test component_name

where 'component_name' is the name of a specific component in the PR. To get a list of the components that changed in the PR, use the analyze tool.
Language that are currently supported: Python, Java, C++, JavaScript, TypeScript.

Configuration options:

  • num_tests: number of tests to generate. Default is 3.
  • testing_framework: the testing framework to use. If not set, for Python it will use pytest, for Java it will use JUnit, for C++ it will use Catch2, and for JavaScript and TypeScript it will use jest.
  • avoid_mocks: if set to true, the tool will try to avoid using mocks in the generated tests. Note that even if this option is set to true, the tool might still use mocks if it cannot generate a test without them. Default is true.
  • extra_instructions: Optional extra instructions to the tool. For example: "use the following mock injection scheme: ...".
  • file: in case there are several components with the same name, you can specify the relevant file.
  • class_name: in case there are several components with the same name in the same file, you can specify the relevant class name.

See more information about the test tool in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants