This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Verify that generated keypair correctly signs and verifies message #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonianb
reviewed
Sep 19, 2017
src/index.js
Outdated
| const badMessage = hash('This test message should NOT verify.') | ||
| const goodSignature = method.sign(goodMessage, keypair.privateKey) | ||
| if (method.verify(goodMessage, goodSignature, keypair.publicKey) !== true || | ||
| method.verify(badMessage, goodSignature, keypair.publicKey) !== false) { |
There was a problem hiding this comment.
I'm not sure how meaningful the second check is. It seems like it tells us more about the correctness of the signing and verification functionality than the generated keypair.
There was a problem hiding this comment.
True. I'll go ahead and remove it.
intelliot
force-pushed
the
verify-keypair
branch
from
aa71974
to
cd9e342
Compare
|
Merged via 1cf06f0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check in
deriveKeypairto ensure that it always returns good keypairs.