This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Refactor and use TypeScript: #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
intelliot
commented
Jan 23, 2019
intelliot
commented
- Migrate to TypeScript and TSLint
- Vendor ripple-address-codec (move dependency into this project)
- Add support for Travis CI (.travis.yml)
- Use "dist/*" for distribution files
- Bump version to 1.0.0-beta.0
- Add yarn.lock
- Migrate to TypeScript and TSLint - Vendor ripple-address-codec (move dependency into this project) - Add support for Travis CI (.travis.yml) - Use "dist/*" for distribution files - Bump version to 1.0.0-beta.0 - Add yarn.lock
|
Why vendor r-a-c?
|
|
To simplify, reducing the number of places to look for things |
FredKSchott
reviewed
Jan 24, 2019
| }, | ||
| "scripts": { | ||
| "compile": "babel --optional runtime -d distrib/npm/ src/", | ||
| "compile": "tsc", | ||
| "compile-babel": "babel --optional runtime -d distrib/npm/ src/", |
There was a problem hiding this comment.
why two compiles? Can we get rid of Babel now that we're using TS?
There was a problem hiding this comment.
Good point - yes, I think we can get rid of Babel
|
LGTM! |
|
Gonna vendor it into ripple lib too?
|
|
I think we'll expose the necessary functionality from ripple-keypairs |
|
Seems kind of gratuitous
|
package.json
Outdated
| "distrib/npm/*", | ||
| "bin/*", | ||
| "build/*", | ||
| "dist/*", | ||
| "test/*" |
There was a problem hiding this comment.
Can this also be removed/is it necessary to publish the tests to NPM?
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.