Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake upgrade and rippled 1.7 fixes #22

Closed
wants to merge 4 commits into from

Conversation

biddisco
Copy link

A couple of updates to the demo that allow it to work with the latest rippled and some cmake improvements.

This allows Rippled to be used from a local binary install,
or FetchContent can either download it or use a local source tree
and build it as a subproject.
Remove old git submodule (obsolete)
Update docs/readme to reflect changes in build instructions
@biddisco biddisco force-pushed the cmake-upgrade branch 16 times, most recently from babd2b1 to 992570b Compare January 14, 2021 13:42
@ximinez
Copy link
Collaborator

ximinez commented Jan 14, 2021

Hi! Thank you for your contribution and taking on the effort to bring this project more up to date. It's definitely been neglected. Part of the reason is that the "xrpl_core" module more-or-less replaces this project.

You can see an example of that replacement in a formerly-dependent project in the changeset ripple/validator-keys-tool@bb532eb in the "validator-keys-tool" project, which bears a lot of similarity, but went about it slightly differently. That project has also more recently been updated so that CI works consistently.

@biddisco
Copy link
Author

That's great. I'll switch over to the other project - I just tried building it and made one small fix. If this project has been discontinued, then it might be an idea to update the project description and/or delete this one.

@biddisco
Copy link
Author

The other project has all the FetchContent stuff working, and has the right travis setup. Closing this as it's obolete.

@biddisco biddisco closed this Jan 14, 2021
@ximinez
Copy link
Collaborator

ximinez commented Jan 14, 2021

It hasn't been discontinued so much as neglected, but thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants