This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
Fix payment history API earliest_first parameter and compare transactions on ledger order
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (typeof val === 'number') { | ||
| return val.toString(); | ||
| } else if (typeof val === 'object') { | ||
| return _.mapValues(val, toString); |
There was a problem hiding this comment.
toString returns non-string return type. Could make toStringValues a recursive function
alandotcom
force-pushed
the
compare-transactions
branch
from
8a1c8a9
to
2f074dd
Compare
added 2 commits
April 14, 2015 17:36
…dger... ...instead of lexicographical order. Also, remove custom compareTransaction function for api/transactions
alandotcom
force-pushed
the
compare-transactions
branch
from
2f074dd
to
0d1d0fa
Compare
|
@clark800 updated |
|
LGTM |
alandotcom
added a commit
that referenced
this pull request
Apr 15, 2015
Fix payment history API `earliest_first` parameter and compare transactions on ledger order
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in earliest_first query parameter for Payment History API