This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
Cherry pick several fixes from develop #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alandotcom
commented
Apr 15, 2015
alandotcom
commented
- Fixing a bug in the payment history API
- Sorting transactions in getAccountTransactions based on the actual ledger order
- Updating knex, ripple-lib-transaction-parser (update includes bug fixes), ripple-lib (0.12.3), winston, and lodash
| "sqlite3": "^3.0.2", | ||
| "supertest": "^0.13.0", | ||
| "winston": "^0.7.3" | ||
| "winston": "^1.0.0" |
There was a problem hiding this comment.
Also, updating winston and ripple-lib.
added 4 commits
April 15, 2015 09:56
…dger... ...instead of lexicographical order. Also, remove custom compareTransaction function for api/transactions
alandotcom
force-pushed
the
hotfix/cherry-pick
branch
from
2d64a85
to
b4a8aa1
Compare
|
LGTM |
alandotcom
added a commit
that referenced
this pull request
Apr 15, 2015
Cherry pick several fixes from develop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.