Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI usage statement doesn't include manifest and validator_info (Version: 1.5.0-rc1) #3318

Closed
mDuo13 opened this issue Mar 25, 2020 · 1 comment
Closed

CLI usage statement doesn't include manifest and validator_info (Version: 1.5.0-rc1) #3318

mDuo13 opened this issue Mar 25, 2020 · 1 comment
Labels
Documentation README changes, code comments, etc. Good First Issue Great issue for a new contributor

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Mar 25, 2020

Issue Description

The usage statement does list the manifest and validator_info commands, added by #3197.

Steps to Reproduce

Print the usage statement:

rippled -h

Expected Result

The result should list all supported commands.

Actual Result

The usage statement does not list either manifest or validator_info.

Environment

Arch Linux, x86_64, self-compiled v1.5.0-rc1.

Supporting Files

The commands portion of the usage statement is in printHelp() of Main.cpp.

It might be possible to make the usage statement dynamic. Much of the necessary info is in Handler.cpp although some of the parameter parsing isn't.
@mDuo13 mDuo13 added Bug Good First Issue Great issue for a new contributor Documentation README changes, code comments, etc. and removed Bug labels Mar 25, 2020
@mDuo13 mDuo13 added this to Awaiting Triage in XRPL 1.6 via automation Mar 25, 2020
@carlhua carlhua removed this from Awaiting Triage in XRPL 1.6 Jun 15, 2020
@carlhua carlhua added this to Awaiting Triage in XRPL 1.7 via automation Jun 15, 2020
@mDuo13 mDuo13 removed this from Awaiting Triage in XRPL 1.7 Mar 15, 2021
@nova141
Copy link

nova141 commented Sep 20, 2021

was this issue fixed? if not id gladly like to work on it

@ckeshava ckeshava mentioned this issue Jul 15, 2022
Closed
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Jul 19, 2022
Update command-line usage help message (fixes XRPLF#3318)
6010388
legleux pushed a commit to legleux/rippled that referenced this issue Sep 23, 2022
@legleux
Update command-line usage help message (fixes XRPLF#3318)
f1a7392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation README changes, code comments, etc. Good First Issue Great issue for a new contributor
Projects
Core Ledger
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mDuo13 @nova141