Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify syntax version for ripple.proto file #2007

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@bachase
Copy link
Contributor

bachase commented Feb 8, 2017

This change eliminates a warning about unspecified syntax version when using
a newer proto3 compiler.

This is a copy of #2001 that I will manage rebasing as needed on behalf of @MarkusTeufelberger .

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 8, 2017

Codecov Report

Merging #2007 into develop will decrease coverage by -0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2007      +/-   ##
===========================================
- Coverage    67.25%   67.25%   -0.01%     
===========================================
  Files          683      683              
  Lines        49231    49231              
===========================================
- Hits         33112    33109       -3     
- Misses       16119    16122       +3
Impacted Files Coverage Δ
src/ripple/core/impl/JobQueue.cpp 86.17% <0%> (-0.47%)
src/ripple/app/ledger/impl/LedgerMaster.cpp 44.41% <0%> (-0.23%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460dd8f...fdb4358. Read the comment docs.

Specify syntax version for ripple.proto file:
This change eliminates a warning about unspecified syntax version when using
a newer proto3 compiler.

@bachase bachase force-pushed the bachase:proto branch from 04a0af3 to fdb4358 Mar 1, 2017

@bachase

This comment has been minimized.

Copy link
Contributor Author

bachase commented Mar 1, 2017

Rebased on 0.60.0-b5

@seelabs

This comment has been minimized.

Copy link
Contributor

seelabs commented Mar 1, 2017

In 0.60.0-b7

@seelabs seelabs closed this Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.