Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] Change conflicting example websocket port #2726

Closed
wants to merge 1 commit into from

Conversation

miguelportilla
Copy link
Contributor

@miguelportilla miguelportilla commented Oct 17, 2018

The example configuration file uses port 5005 for the public websocket which conflicts with the RPC port.

@ripplelabs-jenkins
Copy link
Collaborator

Jenkins Build Summary

Built from this commit

Built at 20181017 - 16:42:00

Test Results

Build Type Log Result Status
msvc.Debug logfile 1068 cases, 0 failed, t: 537s PASS ✅
gcc.Release
-Dassert=ON,
MANUAL_TESTS=true
logfile 1101 cases, 0 failed, t: 6m3s PASS ✅
docs,
TARGET=docs
logfile 1 cases, 0 failed, t: 0m1s PASS ✅
gcc.Debug
-Dcoverage=ON,
TARGET=coverage_report,
SKIP_TESTS=true
logfile 1071 cases, 0 failed, t: 16m31s PASS ✅
msvc.Debug,
NINJA_BUILD=true
logfile 1068 cases, 0 failed, t: 555s PASS ✅
clang.Debug logfile 1071 cases, 0 failed, t: 3m12s PASS ✅
rpm logfile 1071 cases, 0 failed, t: n/a PASS ✅
clang.Debug
-Dunity=OFF
logfile 1071 cases, 0 failed, t: 5m35s PASS ✅
gcc.Debug logfile 1071 cases, 0 failed, t: 3m28s PASS ✅
clang.Release
-Dassert=ON
logfile 1071 cases, 0 failed, t: 5m42s PASS ✅
gcc.Debug
-Dunity=OFF
logfile 1071 cases, 0 failed, t: 11m29s PASS ✅
msvc.Debug
-Dunity=OFF
logfile 1068 cases, 0 failed, t: 1190s PASS ✅
gcc.Release
-Dassert=ON
logfile 1071 cases, 0 failed, t: 6m7s PASS ✅
gcc.Debug
-Dstatic=OFF
logfile 1071 cases, 0 failed, t: 3m29s PASS ✅
gcc.Debug
-Dstatic=OFF -DBUILD_SHARED_LIBS=ON
logfile 1071 cases, 0 failed, t: 3m24s PASS ✅
msvc.Release logfile 1068 cases, 0 failed, t: 393s PASS ✅
gcc.Debug,
NINJA_BUILD=true
logfile 1071 cases, 0 failed, t: 3m2s PASS ✅
clang.Debug
-Dunity=OFF -Dsan=address,
PARALLEL_TESTS=false,
DEBUGGER=false
logfile 1071 cases, 0 failed, t: 8m2s PASS ✅
clang.Debug
-Dunity=OFF -Dsan=undefined,
PARALLEL_TESTS=false
logfile 1071 cases, 0 failed, t: 12m41s PASS ✅

@mellery451 mellery451 added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Oct 19, 2018
@mellery451
Copy link
Contributor

in 1.2.0-b4 as d5c0e12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants