Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes is_win more readable and idiomatic #318

Merged
merged 1 commit into from
Jun 30, 2015

Conversation

mambocab
Copy link
Contributor

This is just a little more compact and easy to read. Jankily tested from the interpreter:

>>> from ccmlib import common
>>> import inspect
>>> inspect.getsourcelines(common.is_win)  # check that I'm using my new implementation
(['def is_win():\n', '    return sys.platform in ("cygwin", "win32")\n'], 215)
>>> # I totally am
...
>>> common.is_win()
False
>>> import sys ; sys.platform = 'cygwin'
>>> common.is_win()
True

@ptnapoleon
Copy link
Contributor

+1

ptnapoleon added a commit that referenced this pull request Jun 30, 2015
makes is_win more readable and idiomatic
@ptnapoleon ptnapoleon merged commit 9749956 into riptano:master Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants