CASSANDRA-16411 CASSANDRA-16296 Fix topology corruption on joining no… #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlasica
reviewed
Jan 29, 2021
tlasica
reviewed
Jan 29, 2021
|
Swtiched to erroring out, added a ccm test and on the dtest PR you can see the dtests changes + CI runs. |
|
Apologies guys, I had left behind some code from the previous commit, my bad. Removed now. |
tlasica
approved these changes
Feb 3, 2021
|
I have added CI for this latest commit on the dtests PR to keep everything in the same place #justfyi |
adelapena
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
I am also not one of the ccm code gurus on the project but I think the proposed solution is deterministic and makes the things clear. I would run it also as a comment in the slack channel to see if it might affect someone in a way but I don't see how. My only concern is it affects the CI before a release :-) Good catch of the bug
|
I can run it through Slack +1 |
ekaterinadimitrova2
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…des without DC