Make a copy so nodes can't mutate each others environment variables #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweisberg
force-pushed
the
cassandra-19551
branch
from
c952122
to
f30b7b7
Compare
Patch by Ariel Weisberg; Reviewed by Joshua McKenszie for CASSANDRA-19551
aweisberg
force-pushed
the
cassandra-19551
branch
from
f30b7b7
to
88ef54e
Compare
|
LGTM. Passing curiosity if there's anything else we're assigning to a ref that could later be mutated, but looks like it'd just be the cluster object which... yeah. If we're changing that outside we have bigger problems. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.